PropHunt 1.5 Bug Thread

PropHunt 1.5 Bug Thread

It's about time we had a place to consolidate version 1.5 bugs :p

Anyway, the function I just wrote (GetAnimeEnt) seems to have fixed a lot of bugs - I've just had several rounds across 2 maps with ~16 players and absolutely nothing went wrong. No props in spec, no crits, no scouts with weapons etc. etc.

PHP:

// much more reliable than an entity index array for cross-round code, since indexes are fucked with between rounds on srcds (only?)
stock GetAnimeEnt(client){
    new client2, ent;
    while(IsValidEntity(ent) && (ent = FindEntityByClassname(ent, "prop_dynamic")) != -1)
    {
        client2 = GetEntPropEnt(ent, Prop_Send, "m_hOwnerEntity");
        if(client2 == client){
            return ent;
        }
    }
    return -1;
}

Basically it replaces g_AnimeModel (a large array of entity indexes) for most functions (especially prop removal), since entity indexes are changed between rounds due to all entities being destroyed and recreated. m_hOwnerEntity is a property of all entities (CBaseEntity) which rarely gets used - I've taken advantage of it in the spawn function and set it to the client whose prop it is.

 

Just found and fixed a fucking huge timer issue which was almost certainly the cause of most of the 1.5 problems.

If a certain combination of red and blu wins occurred (absolutely no idea what), the round would be stuck permanently over (internally) resulting in the 100% crits at round end internal code running, prop spawn code not running, pyro unfreeze code not running etc.

 

Fixed the scout thing - it was a bug in the code which removes natasha, sniper and jarate D:

And because that was the first thing in the event code, Timer_Start amongst other things never got fired.

 

That heavy one has been bothering me for a long time..

 

I've played 58 hours, only getting into it now again due to lack of internet. Plus im not at home now. Will be going home tomorrow.

 

Fuck you shinkz

 

Something is making the server FPS drop considerably after a few hours uptime (manifests as stupidly high pings and loss of connection), and since it's only happening to PropHunt and we've confirmed it's not the stats, the most likely causes would be unexpected recursion (which there has been quite a lot of lately) or a quirk of the SDK Hooks extension.

In other words, I'm not really sure what the cause is yet.

 

That's completely impossible unless the pyro's extra speed is doing it.

 

Just fixed a potential bug where longer timers such as the round and hiding time timers could carry over on map change.

This only applies for admin or RTV mapchanges though - if the round ended prior to the map change the timers would have been stopped anyway.

I've also fixed a minor performance issue with StartTouch (CP bonus) where IsClientInGame would have been called at least once per frame without reason.

And it was running a full on string comparison for each client per frame to block right click for flamethrower only, which is pointless as right click doesn't do anything on slot 2 and 3 weapons anyway.

 

We've fixed the lag - it was running Format on a 64 byte string per client per frame. Not very nice for the server CPU.

That's about 175kb of bullshit per second on a full server.